[jitsi-dev] [libjitsi] Increase the send-side bandwidth estimator max bitrate limit to 20Mbps. (#84)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/84

-- Commit Summary --

  * Increase the send-side bandwidth estimator max bitrate limit to 20Mbps.

-- File Changes --

    M src/org/jitsi/impl/neomedia/rtp/sendsidebandwidthestimation/BandwidthEstimatorImpl.java (2)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/84.patch
https://github.com/jitsi/libjitsi/pull/84.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/84


#2

Merged #84.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/84#event-554068023


#3

Thank you, @bgrozev!

If you allow me, a couple of comments (which I think are out of the scope of this pull request):

- I didn't really understand why you increased the maxBitrate value. I did try searching the WebRTC source code in Chromium and I believe I found the old value but not the new value. It may make sense to add a javadoc stating why you raised this limit.

- The fields minBitrate and maxBitrate are static finals. I didn't find them in the WebRTC source code in Chromium so it doesn't look to me like you're trying to preserve outside names. Consequently, wouldn't it be consistent to have them in uppercase like it's usual for Java?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/84#issuecomment-185369002


#4

Thanks, @lyubomir. The constants were originally based on constants from webrtc.org, but since we are changing them anyway, I renamed them in #85. The reason we increase the max is because we want our estimation to grow sufficiently in a scenario where we are sending (or forwarding) multiple streams.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/84#issuecomment-185381839