[jitsi-dev] [libjitsi] Also cache certificate and fingerprint in DtlsControlImpl (#109)


#1

No reasons to compute a new cert with the same keypair

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/109

-- Commit Summary --

  * Also cache certificate and fingerprint in DtlsControlImpl

-- File Changes --

    M src/org/jitsi/impl/neomedia/transform/dtls/DtlsControlImpl.java (103)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/109.patch
https://github.com/jitsi/libjitsi/pull/109.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197933115


#3

Jenkins: add to whitelist

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197939558


#4

@ibauersachs do you want me to also remove the leading '_'

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197941382


#5

Yes.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197964597


#6

@champtar & @ibauersachs, I have my own version in my local clone. May I please take over the merge of this PR?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197968096


#7

You can close this one if you think yours is better.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-197969570


#8

@lyubomir i've updated the commit to remove '_'
can you merge your patch or mine?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#issuecomment-198272716


#9

Merged #109.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/109#event-596632285