[jitsi-dev] [libjitsi] Allow user to specify RSA key generation parameters via configuration. (#67)


#1

Adds two configuration options:
    org.jitsi.impl.neomedia.transform.dtls.RSA_KEY_SIZE
and
    org.jitsi.impl.neomedia.transform.dtls.RSA_KEY_SIZE_CERTAINTY

The first is the size in bits of the RSA key to be presented by the server on a DTLS handshake.
The second is the certainty passed to BigNumber constructor.

Either may be set by java system properties (e.g. -D) or by the jitsi configuration service (sip-communicator.properties).

A sample on a jitsi-videobridge server updating the default of key size to 3072 bit RSA keys:
```$ cat ~/.sip-communicator/sip-communicator.properties
org.jitsi.impl.neomedia.transform.dtls.RSA_KEY_SIZE_CERTAINTY=80
org.jitsi.impl.neomedia.transform.dtls.RSA_KEY_SIZE=3072```

Defaults of 1024 and 80, respectively, remain the same as before. Some minor refactoring to move the numbers out of the method doing the generation.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/67

-- Commit Summary --

  * Allow user to specify RSA key generation parameters via configuration.

-- File Changes --

    M src/org/jitsi/impl/neomedia/transform/dtls/DtlsControlImpl.java (90)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/67.patch
https://github.com/jitsi/libjitsi/pull/67.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67


#2

While I don't need this yet in my project, I would like to see it get added to the lib. Also nice job on the patch.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-161324251


#3

Can one of the admins verify this patch?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-191945345


#4

@bickelj can you please rebase this and fix the conflicts?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-205484075


#5

@ibauersachs I would gladly create a new PR based on the new code and link to it from this one, if that would be acceptable to you (considering what happened last rebase).

It may be several days before I get a chance to do it.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-205533412


#6

I'm sorry this got left behind, we've all been too busy and probably have forgotten about it too.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-205655565


#7

This PR is obsoleted by https://github.com/jitsi/libjitsi/pull/134
Therefore closing.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#issuecomment-208068596


#8

Closed #67.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/67#event-621666902