Thanks @ibauersachs. I would like to avoid throwing an exception in the ctor (I don't have a strong argument against it tho) but creating an empty array when `fciEntries == null` wouldn't hurt performance, so I'd be fine with that. In fact, at least for the time being, this method is not called nor do I plan to call it from anywhere.
But the null checks are not only null checks, they're also length checks (when I check for null I also check for an empty array), so I don't want to completely get rid of these checks. Unless what you're actually saying is that there's no point in checking for the length either because the compiler optimizes this case anyway?
Reply to this email directly or view it on GitHub: