[jitsi-dev] [libjitsi] Add a protocol / CaptureDevice that generate RGB frames (#10)


#1

The frames create a fading from white to black to white...

Also add a custom MediaDevice for convenience to create a CaptureDevice
with different dimension and/or framerate than the default ones.

This CaptureDevice doesn't do much, but can be used for debugging (to generate
video from where you don't have a desktop to record, nor webcam).
You can merge this Pull Request by running:

  git pull https://github.com/Haerezis/libjitsi greyfading

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/libjitsi/pull/10

-- Commit Summary --

  * Add a protocol / CaptureDevice that generate RGB frame that create

-- File Changes --

    A src/org/jitsi/impl/neomedia/jmfext/media/protocol/greyfading/DataSource.java (35)
    A src/org/jitsi/impl/neomedia/jmfext/media/protocol/greyfading/VideoGreyFadingMediaDevice.java (143)
    A src/org/jitsi/impl/neomedia/jmfext/media/protocol/greyfading/VideoGreyFadingStream.java (146)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/10.patch
https://github.com/jitsi/libjitsi/pull/10.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/10


#2

Thanks for the contribution! Some nits:
In VideoGreyFadingMediaDevice.java code duplication can be avoided (e.g. have a single constructor that calls super(), and the other three constructors can call it)

In VideoGreyFadingStream.java:
There are tabs (\t's). By convention we use only spaces. Unnecessary cast on line 93. Formatting on lines 108, 109. Line 123 should use frameSizeInBytes and not data.length. s/remaing/remaining/.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/10#issuecomment-48908757


#3

Thanks for pointing out the errors I made.
I've pushed a commit that should fix theses errors.

Sorry for the tabs, I wrote this class just before switching to spaces, and I didn't pay attention to it :confused: .

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/10#issuecomment-48939842


#4

Merged #10.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/10#event-141421354