[jitsi-dev] Larger Options window and untranslatable strings


#1

Hi,
I want to make some observations:
1. Could be possible to make the Options window (reachable via Tools/Option) resizable or, at least, larger (I suggest at least 610 px)? Some strings (in italian language) appear truncated because of the width of the window and I have no idea to better translate them with shorter strings.
2. The strings in the Events tab in the Options window and the strings about accounts state (Online, Offline, Away, On the phone, Busy, etc.) are not in the translation system, so it is not possible to translate them. Is it possible to insert them in pootle?

Thanks,

Daniel


#2

1. Could be possible to make the Options window (reachable via Tools/Option) resizable or, at least, larger (I suggest at least 610 px)? Some strings (in italian language) appear truncated because of the width of the window and I have no idea to better translate them with shorter strings.

+1 for making the Options window resizable. While there's room for a
larger width, I'm pretty much out of available height.

2. The strings in the Events tab in the Options window and the strings about accounts state (Online, Offline, Away, On the phone, Busy, etc.) are not in the translation system, so it is not possible to translate them. Is it possible to insert them in pootle?

Could you please open an issue for it so that we can take care of it
when our priorities allow us to?
http://jitsi.org/index.php/Development/NewIssue

···

On Sat, Oct 8, 2011 at 2:53 PM, Daniel Zucchetto <dzmail90-voip@yahoo.it> wrote:


#3

2. The strings in the
Events tab in the Options window and the strings about accounts state
(Online, Offline, Away, On the phone, Busy, etc.) are not in the
translation system, so it is not possible to translate them. Is it
possible to insert them in pootle?

I just committed a patch which allows the translation of that config-page. The strings are in Pootle now.

Ingo


#4

+1 for making the Options window resizable. While there's room for a
larger width, I'm pretty much out of available height.

+1, the width has been an issue for the German translation too.
But what's wrong about the height? The config frame already adapts the height to the containing panel?

Yana: Could you please review my attached patch that makes it wider and adds a small border to the top buttons?

Ingo

Make-config-form-wider-and-resizable.patch (2.83 KB)


#5

The frame adapts to the height of the containing panel BUT goes out of
the bottom of the visible area of the screen so I still fail to see
the whole panel.

···

On Sat, Oct 8, 2011 at 5:13 PM, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

But what's wrong about the height? The config frame already adapts the height to the containing panel?


#6

I suppose the border would be a problem for the native mac gui.

-- sent from my mobile

···

On Oct 8, 2011 5:16 PM, "Bauersachs Ingo" <ingo.bauersachs@fhnw.ch> wrote:

> +1 for making the Options window resizable. While there's room for a
> larger width, I'm pretty much out of available height.

+1, the width has been an issue for the German translation too.
But what's wrong about the height? The config frame already adapts the
height to the containing panel?

Yana: Could you please review my attached patch that makes it wider and
adds a small border to the top buttons?

Ingo


#7

Hi Ingo,

+1 for making the Options window resizable. While there's room for a
larger width, I'm pretty much out of available height.

+1, the width has been an issue for the German translation too.
But what's wrong about the height? The config frame already adapts the height to the containing panel?

Yana: Could you please review my attached patch that makes it wider and adds a small border to the top buttons?

When I apply the patch I could no longer see the video advanced options (the window doesn't resize). However I see that Damian is experiencing the same problem with the current version and for me the current version works. We should test these on all operating systems and see what exactly is going wrong and where. I'll have a closer look today.

Cheers,
Yana

···

On Oct 8, 2011, at 4:13 PM, Bauersachs Ingo wrote:

Ingo
<Make-config-form-wider-and-resizable.patch>


#8

I suppose the border would be a problem for the native mac gui.

The buttons-panel is created differently for Mac and Non-Mac. My changes only apply to the Non-Mac variant.

Ingo


#9

Hi

When I apply the patch I could no longer see the video advanced options
(the window doesn't resize). However I see that Damian is experiencing the
same problem with the current version and for me the current version
works. We should test these on all operating systems and see what exactly
is going wrong and where. I'll have a closer look today.

I too see this from time to time on my non-dev instance, but it's not reproducible. Maybe we should stop that automatic resizing completely and let the individual panels handle it themselves (e.g. using scrollbars) when they need more space. AFAIK its normal that windows resize themselves on Mac, but on Windows it feels a bit weird.

Ideas for the panels:
- General: Vertical scrollbar, and put the group name on top of the items to gain more horizontal space
- Audio: Two subtabs: one for the devices and one for the codecs
- Video: Three subtabs: Device; Codecs; Advanced Settings

The audio and video panels would then look similar to the Security panel.

WDYT?

Ingo


#10

Hi all,

is it only me that I cannot no longer access advanced video options?

Thanks
damencho

···

On Sat, Oct 8, 2011 at 8:28 PM, Bauersachs Ingo <ingo.bauersachs@fhnw.ch>wrote:

> I suppose the border would be a problem for the native mac gui.

The buttons-panel is created differently for Mac and Non-Mac. My changes
only apply to the Non-Mac variant.

Ingo


#11

Hi Ingo, all,

Sorry for the lag on this one!

For now I've just applied your patch (making the window resizable) and have made some fixes that should allow the normal resizing of the video configuration form. I've tested it on MacOSX Snow Leopard only and would be curious to know if it's working ok on other OS-es, so don't hesitate to give it a try and play with!

(more inline)

Hi

When I apply the patch I could no longer see the video advanced options
(the window doesn't resize). However I see that Damian is experiencing the
same problem with the current version and for me the current version
works. We should test these on all operating systems and see what exactly
is going wrong and where. I'll have a closer look today.

I too see this from time to time on my non-dev instance, but it's not reproducible. Maybe we should stop that automatic resizing completely and let the individual panels handle it themselves (e.g. using scrollbars) when they need more space. AFAIK its normal that windows resize themselves on Mac, but on Windows it feels a bit weird.

Yes, I agree. We could also think of make the window behave differently on different OS-es, if we find a simple way to do that without duplicating a lot of code.

Ideas for the panels:
- General: Vertical scrollbar, and put the group name on top of the items to gain more horizontal space

I agree. We may put the group label on the same level as the separator.

- Audio: Two subtabs: one for the devices and one for the codecs

I'm not sure if the audio form height needs really to be reduced, but I'm also ok with the tabs.

- Video: Three subtabs: Device; Codecs; Advanced Settings

Again, I prefer it this way, but if the others are ok with the subtabs I'm also ok:)

Cheers,
Yana

···

On Oct 11, 2011, at 10:46 AM, Bauersachs Ingo wrote:

The audio and video panels would then look similar to the Security panel.

WDYT?

Ingo


#12

It sometimes happens that the options frame doesn't adapt its size to the panels. Restarting Jitsi helps.

Ingo

···

-----Original Message-----
From: damencho@damencho.com [mailto:damencho@damencho.com] On Behalf Of
Damian Minkov
Sent: Montag, 10. Oktober 2011 08:44
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Larger Options window and untranslatable strings

Hi all,

is it only me that I cannot no longer access advanced video options?

Thanks
damencho


#13

Hey

Sorry for the lag on this one!

We're all busy :slight_smile:

For now I've just applied your patch (making the window resizable) and have
made some fixes that should allow the normal resizing of the video
configuration form. I've tested it on MacOSX Snow Leopard only and would be
curious to know if it's working ok on other OS-es, so don't hesitate to give
it a try and play with!

Seems to be working fine on Win7.

Hi

When I apply the patch I could no longer see the video advanced options
(the window doesn't resize). However I see that Damian is experiencing the
same problem with the current version and for me the current version
works. We should test these on all operating systems and see what exactly
is going wrong and where. I'll have a closer look today.

I too see this from time to time on my non-dev instance, but it's not
reproducible. Maybe we should stop that automatic resizing completely and let
the individual panels handle it themselves (e.g. using scrollbars) when they
need more space. AFAIK its normal that windows resize themselves on Mac, but
on Windows it feels a bit weird.

Yes, I agree. We could also think of make the window behave differently on
different OS-es, if we find a simple way to do that without duplicating a lot
of code.

The two most important tabs are General and Video. If we find a way to make them smaller then it's ok for me if the window resizes on Windows too. That would avoid modifying too much.

Ideas for the panels:
- General: Vertical scrollbar, and put the group name on top of the items

to gain more horizontal space

I agree. We may put the group label on the same level as the separator.

- Audio: Two subtabs: one for the devices and one for the codecs

I'm not sure if the audio form height needs really to be reduced, but I'm
also ok with the tabs.

The audio form definitely doesn't need it. The idea was to make it consistent with the video panel.

- Video: Three subtabs: Device; Codecs; Advanced Settings

Again, I prefer it this way, but if the others are ok with the subtabs I'm
also ok:)

Well the problem is that the currently expanding panel with the "More Settings" causes to overflow the entire screen on some Netbooks/Notebooks. Currently the video window has 684px on Win7, when the netbook only has 600px -> ups. Therefore the tab idea.
The codecs and advanced settings could also be placed in the same tab to reduce the tab count, but that depends then on what the audio pane does.

A completely different option would be to do it similar as the advanced config UI of VLC: A treeview. But that would require a major refactoring...

Regards,
Ingo

···

On Oct 11, 2011, at 10:46 AM, Bauersachs Ingo wrote:


#14

Hi Ingo,

Hey

Sorry for the lag on this one!

We're all busy :slight_smile:

For now I've just applied your patch (making the window resizable) and have
made some fixes that should allow the normal resizing of the video
configuration form. I've tested it on MacOSX Snow Leopard only and would be
curious to know if it's working ok on other OS-es, so don't hesitate to give
it a try and play with!

Seems to be working fine on Win7.

Great, thanks.

Hi

When I apply the patch I could no longer see the video advanced options
(the window doesn't resize). However I see that Damian is experiencing the
same problem with the current version and for me the current version
works. We should test these on all operating systems and see what exactly
is going wrong and where. I'll have a closer look today.

I too see this from time to time on my non-dev instance, but it's not
reproducible. Maybe we should stop that automatic resizing completely and let
the individual panels handle it themselves (e.g. using scrollbars) when they
need more space. AFAIK its normal that windows resize themselves on Mac, but
on Windows it feels a bit weird.

Yes, I agree. We could also think of make the window behave differently on
different OS-es, if we find a simple way to do that without duplicating a lot
of code.

The two most important tabs are General and Video. If we find a way to make them smaller then it's ok for me if the window resizes on Windows too. That would avoid modifying too much.

Ideas for the panels:
- General: Vertical scrollbar, and put the group name on top of the items

to gain more horizontal space

I agree. We may put the group label on the same level as the separator.

- Audio: Two subtabs: one for the devices and one for the codecs

I'm not sure if the audio form height needs really to be reduced, but I'm
also ok with the tabs.

The audio form definitely doesn't need it. The idea was to make it consistent with the video panel.

- Video: Three subtabs: Device; Codecs; Advanced Settings

Again, I prefer it this way, but if the others are ok with the subtabs I'm
also ok:)

Well the problem is that the currently expanding panel with the "More Settings" causes to overflow the entire screen on some Netbooks/Notebooks. Currently the video window has 684px on Win7, when the netbook only has 600px -> ups. Therefore the tab idea.
The codecs and advanced settings could also be placed in the same tab to reduce the tab count, but that depends then on what the audio pane does.

Ok, I understand. If you have the time to implement the tab idea, I'm ok with that, otherwise could you please create an issue on the tracker for this one? The same for the General tab, if you don't have the time to work on it, could you please create an issue?

A completely different option would be to do it similar as the advanced config UI of VLC: A treeview. But that would require a major refactoring...

Yep, this one would take more time:)

Cheers,
Yana

···

On Oct 24, 2011, at 7:06 PM, Bauersachs Ingo wrote:

On Oct 11, 2011, at 10:46 AM, Bauersachs Ingo wrote:

Regards,
Ingo


#15

Hey Yana

[snip]

Ok, I understand. If you have the time to implement the tab idea, I'm ok with
that, otherwise could you please create an issue on the tracker for this one?
The same for the General tab, if you don't have the time to work on it, could
you please create an issue?

I created the tabs for both audio and video. The two panels are based on the same code with lots of if(type==audio). If we want to remove the tabs from the audio panel again at some point, we should probably separate them into different classes.

Additionally I modified the general config panel so that the section names are above the controls. As this needed even more horizontal space, I put the settings into a scrollviewer.

Could you please take a look and check if everything is ok, especially on MacOS?

The only tab that is left higher than 600px is the advanced panel. I hesitated to make it smaller because I'm not sure how each advanced plugin behaves.

Regards,
Ingo


#16

Hey

Here you go...

Regards,
Ingo

···

-----Original Message-----
From: Emil Ivov [mailto:emcho@jitsi.org]
Sent: Sonntag, 30. Oktober 2011 01:54
To: dev@jitsi.java.net
Cc: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Larger Options window and untranslatable strings

Hey Ingo,

Could you please send a couple of screenshots showing how thing look for you?

Thanks,
Emil

--sent from my mobile

On 30 oct. 2011, at 00:55, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

> Hey Yana
>
>> [snip]
>>
>> Ok, I understand. If you have the time to implement the tab idea, I'm ok
with
>> that, otherwise could you please create an issue on the tracker for this
one?
>> The same for the General tab, if you don't have the time to work on it,
could
>> you please create an issue?
>
> I created the tabs for both audio and video. The two panels are based on
the same code with lots of if(type==audio). If we want to remove the tabs
from the audio panel again at some point, we should probably separate them
into different classes.
>
> Additionally I modified the general config panel so that the section names
are above the controls. As this needed even more horizontal space, I put the
settings into a scrollviewer.
>
> Could you please take a look and check if everything is ok, especially on
MacOS?
>
> The only tab that is left higher than 600px is the advanced panel. I
hesitated to make it smaller because I'm not sure how each advanced plugin
behaves.
>
> Regards,
> Ingo


#17

Hi Ingo,

That was fast :slight_smile: Looks great!!

While looking at the screenshots I noticed some problems, not especially related to your modifications, but I thought it's worth mentioning them here, so that we take care of them at some point.

Here's a small list:

- In the Audio / Devices form there's no space between combo boxes.
- In Video / More settings the "Custom frame rate" combo box should be made non-opaque (to remove the grey background)
- May be we can put a border to all non-list forms (JList has its own border), because it looks somehow weird to have the tab "flying" in the middle of the blue background.

Cheers,
Yana

···

On Oct 30, 2011, at 8:44 AM, Bauersachs Ingo wrote:

Hey

Here you go...

Regards,
Ingo

-----Original Message-----
From: Emil Ivov [mailto:emcho@jitsi.org]
Sent: Sonntag, 30. Oktober 2011 01:54
To: dev@jitsi.java.net
Cc: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Larger Options window and untranslatable strings

Hey Ingo,

Could you please send a couple of screenshots showing how thing look for you?

Thanks,
Emil

--sent from my mobile

On 30 oct. 2011, at 00:55, Bauersachs Ingo <ingo.bauersachs@fhnw.ch> wrote:

Hey Yana

[snip]

Ok, I understand. If you have the time to implement the tab idea, I'm ok

with

that, otherwise could you please create an issue on the tracker for this

one?

The same for the General tab, if you don't have the time to work on it,

could

you please create an issue?

I created the tabs for both audio and video. The two panels are based on

the same code with lots of if(type==audio). If we want to remove the tabs
from the audio panel again at some point, we should probably separate them
into different classes.

Additionally I modified the general config panel so that the section names

are above the controls. As this needed even more horizontal space, I put the
settings into a scrollviewer.

Could you please take a look and check if everything is ok, especially on

MacOS?

The only tab that is left higher than 600px is the advanced panel. I

hesitated to make it smaller because I'm not sure how each advanced plugin
behaves.

Regards,
Ingo

<options-audio-devices.png><options-audio-encodings.png><options-general.png><options-video-devices.png><options-video-encodings.png><options-video-moresettings.png>


#18

Hey

That was fast :slight_smile: Looks great!!

Thanks :slight_smile:

While looking at the screenshots I noticed some problems, not especially
related to your modifications, but I thought it's worth mentioning them here,
so that we take care of them at some point.

Here's a small list:

- In the Audio / Devices form there's no space between combo boxes.

Fixed.

- In Video / More settings the "Custom frame rate" combo box should be made
non-opaque (to remove the grey background)

I guess you meant the checkbox. -> Fixed.
The LCD of my Laptop is too crappy I'm unable to distinguish the blue from the grey there :slight_smile:

- May be we can put a border to all non-list forms (JList has its own
border), because it looks somehow weird to have the tab "flying" in the
middle of the blue background.

Yeah, that makes sense. But I guess the option to create such a border would be tabbed pane itself (maybe through a constructor option). It would however require to change several content panels (remove borders, add padding, ...) so that it doesn't look even more strange afterwards.
-> Postponed for me.

Cheers,
Yana

Regards,
Ingo