[jitsi-dev] [jitsi] VoiceCall Target resource (#37)


#1

This small changes allows you to select the resource you want to call (if multiples exist).
Before, you saw the target name (without resource) the amount of times of resources +1.
No matter which one chosen, called always the preferred one.

The hack in my solution is not the best one, but it works at least for xmpp voice.

I don't know if this problem would exist with other protocols too.
You can merge this Pull Request by running:

  git pull https://github.com/ArcticSnowSky/jitsi master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi/pull/37

-- Commit Summary --

  * VoiceCall Target resource in chat/toolBars/ added.
  * Unneeded change forgotten to remove

-- File Changes --

    M src/net/java/sip/communicator/impl/gui/main/chat/toolBars/MainToolBar.java (13)
    M src/net/java/sip/communicator/impl/protocol/jabber/OperationSetBasicTelephonyJabberImpl.java (5)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/37.patch
https://github.com/jitsi/jitsi/pull/37.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/37


#2

I've checked out your changes and tested using Google Talk account (XMPP). It works, the dropdown menu correctly shows the resource name, and audio calling works as it normally would.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/37#issuecomment-46806630


#3

@@ -268,7 +268,10 @@ public void callStateChanged(CallChangeEvent ev)
             Iterable<PacketExtension> sessionInitiateExtensions)
         throws OperationFailedException
     {
- return createOutgoingCall(call, calleeAddress, null, null);
+ if (calleeAddress.contains("/"))

Might be better to call smack StringUtils parseResource, and check if resource string is non-empty. That way, if the method to check resource changes, it will still work correctly.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/37/files#r14106562


#4

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/37#issuecomment-218826989


#5

iCLA signed May 29. 2016

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/37#issuecomment-223056126