[jitsi-dev] [jitsi-videobridge] Use getLocalHostLanAddress to avoid using 127.0.0.1 as the local IP (#128)


#1

The code is mostly taken from here, which should also be Apache-licensed
https://issues.apache.org/jira/browse/JCS-40

It fixes the second problem in https://github.com/jitsi/jitsi-videobridge/issues/102

It might be desirable anyway to allow to configure "the" IP address. Suggestions for a property name?
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/128

-- Commit Summary --

  * Use getLocalHostLanAddress to avoid using 127.0.0.1 as the local IP address.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/RawUdpTransportManager.java (82)
    A src/test/java/org/jitsi/videobridge/RawUdpConferenceTest.java (92)
    M src/test/java/org/jitsi/videobridge/VideoBridgeTestSuite.java (1)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/128.patch
https://github.com/jitsi/jitsi-videobridge/pull/128.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/128


#2

This looks good to me, but can you please fix the formatting? We have a strict limit of 80 chars per line and use package imports (e.g. import org.junit.*) everywhere.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/128#issuecomment-186409739


#3

Okay. Better now?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/128#issuecomment-187063426


#4

Merged #128.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/128#event-559867423


#5

Yes, perfect. Thank you!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/128#issuecomment-187242787