[jitsi-dev] [jitsi-videobridge] Updates the "inLastN" property of a VideoChannel when changes to the … (#137)


#1

…"lastN" set occur.

Torture passed, manually tested with the scenario described in #132.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/137

-- Commit Summary --

  * Updates the "inLastN" property of a VideoChannel when changes to the "lastN" set occur.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/LastNController.java (92)
    M src/main/java/org/jitsi/videobridge/VideoChannel.java (24)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/137.patch
https://github.com/jitsi/jitsi-videobridge/pull/137.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137


#2

I will do some testing on this tomorrow, thanks for the fix!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#issuecomment-184962588


#3

+ {
+ endpoint = conference.getEndpoint(id);
+ }
+ }
+ }
+
+ return getVideoChannels(endpoint);
+ }
+
+ /**
+ * Gets the list of {@link VideoChannel}s belonging to an endpoint.
+ *
+ * @param endpoint the endpoint.
+ * @return the {@link VideoChannel}s of the endpoint.
+ */
+ private List<VideoChannel> getVideoChannels(Endpoint endpoint)

Do we really need this since we have `endpoint.getChannels(MediaType.VIDEO)`?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137/files#r53182822


#4

LGTM. @davidertel do you still want to do some testing before I merge this?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#issuecomment-185324929


#5

I just ran some tests and confirmed this fixes the issue I was seeing. Thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#issuecomment-185327673


#6

George, I did some testing and it looks good to me. Thank you again

···

On Feb 17, 2016, at 12:54 PM, George Politis <notifications@github.com> wrote:

LGTM. @davidertel do you still want to do some testing before I merge this?


Reply to this email directly or view it on GitHub.

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#issuecomment-185708310


#7

Merged #137.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#event-555261313


#8

@lsevans, @davidertel thank you!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/137#issuecomment-185783555