[jitsi-dev] [jitsi-videobridge] Update bcprov-jdk15on to 1.54 (#123)


#1

Quickly run tested with Firefox Nightly 46 and Chrome 47

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/123

-- Commit Summary --

  * Update bcprov-jdk15on to 1.54

-- File Changes --

    M pom.xml (6)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/123.patch
https://github.com/jitsi/jitsi-videobridge/pull/123.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123


#2

Can one of the admins verify this patch?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-192016128


#3

Jenkins: it's ok to test.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205464411


#4

Note: this would be obsoleted by https://github.com/jitsi/jitsi-universe/pull/5

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205479959


#5

Oh, thank you very much, @ibauersachs! Are you saying that I should merge your PR, then close this one, and remove the bouncycastle dependency from jitsi-videobridge?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205482933


#6

@lyubomir Please do in the following order:
1) merge the ice4j PRs. If that is done, I'll publish ice4j 1.0 on Maven Central.
2) merge jitsi-universe#5
3) set ice4j to version 1.0 in jitsi-universe (I can create a follow-up PR for that)
4) update the pinned version of jitsi-universe in videobridge and remove the BouncyCastle version (not the dependency).
5) Do the same as in 4 for jicofo, maybe jigasi (haven't looked at that)

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205488947


#7

Thank you, @ibauersachs! I'll try to do as you said.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205489584


#8

@lyubomir Thanks! I updated the comment before to include libjitsi updates.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#issuecomment-205491931


#9

Merged #123.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/123#event-616231014