[jitsi-dev] [jitsi-videobridge] Support RFC 4145 setup attribute (#191)


#1

Reports the value of setup attribute defined by https://tools.ietf.org/html/rfc4145#section-4 (that libjitsi's DTLS supports already) from Videobridge to the API client allocating the channel. Takes into account the value sent by the API client to Videobridge. Requires https://github.com/jitsi/libjitsi/pull/119 and https://github.com/jitsi/ice4j/pull/56.

The following modifications were applied while trying to remove a 1 second hard minimum on connectivity establishment between Videobridge and Chrome/WebRTC. Related modifications in lib-jitsi-meet (i.e. which will be introduced in a branch there with the same name) (will) depend on these.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/191

-- Commit Summary --

  * Renames the field isControlling to controlling.
  * Simplifies and/or clarifies and manually formats source code, mostly for readability (while reading the source code in the context of early DTLS support).
  * Moves as much as presumably possible of the initialization of DtlsControlImpl closer to its construction (with a sight on early DTLS support).
  * Uses DtlsControlImpl instead of DtlsControl where our implementations actually require the former.
  * Simplifies and/or clarifies and manually formats source code, mostly for readability (while reading the source code in the context of early DTLS support).
  * Splits a long method into multiple shorter methods.
  * Supports the setup attribute defined by https://tools.ietf.org/html/rfc4145#section-4.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/IceUdpTransportManager.java (536)
    M src/main/java/org/jitsi/videobridge/RawUdpTransportManager.java (3)
    M src/main/java/org/jitsi/videobridge/RtpChannel.java (17)
    M src/main/java/org/jitsi/videobridge/SctpConnection.java (2)
    M src/main/java/org/jitsi/videobridge/TransportManager.java (3)
    M src/main/java/org/jitsi/videobridge/influxdb/LoggingHandler.java (33)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/191.patch
https://github.com/jitsi/jitsi-videobridge/pull/191.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/191


#2

Merged #191.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/191#event-605762675