[jitsi-dev] [jitsi-videobridge] Support for generic cloud based metric service added (#42)


#1

You can merge this Pull Request by running:

  git pull https://github.com/zbettenbuk/jitsi-videobridge master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-videobridge/pull/42

-- Commit Summary --

  * Support for generic cloud based metric service added

-- File Changes --

    M src/org/jitsi/videobridge/Channel.java (12)
    M src/org/jitsi/videobridge/Conference.java (7)
    M src/org/jitsi/videobridge/Content.java (10)
    M src/org/jitsi/videobridge/RtpChannel.java (7)
    M src/org/jitsi/videobridge/Videobridge.java (18)
    A src/org/jitsi/videobridge/metrics/MetricService.java (171)
    A src/org/jitsi/videobridge/metrics/MetricServiceActivator.java (39)
    A src/org/jitsi/videobridge/metrics/MetricServicePublisher.java (67)
    M src/org/jitsi/videobridge/osgi/OSGi.java (3)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/42.patch
https://github.com/jitsi/jitsi-videobridge/pull/42.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42


#2

ah, that is much easier to read and review, thanks.

The functionality seems similar to both the stats publisher (for things like the number of channels) and the influxdb logging module (for logging the length of a particular conference).

Would it make sense to reuse some of the infrastructure for this?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42#issuecomment-65435263


#3

I tried so but that's a different path of the configuration and didn't want to break the influxdb workflow. The events defined there would have been quite good for me (on the event level) but they use much more complex data while I wanted to stick to key-value pairs that most of the cloud providers like NewRelic or AppNeta use.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42#issuecomment-65439077


#4

Merged #42.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42#event-202065311


#5

@bgrozev Does the bridge have a different code convention than (lib)jitsi? If not, then this stuff should be properly formatted.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42#issuecomment-65553289


#6

It is, in 075002883391b75da1729bdfd807af628006b5ae

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/42#issuecomment-65553406