[jitsi-dev] [jitsi-videobridge] Fixed bug in ant script to create dist directory if it is not there (#50)


#1

$ ant dist.macosx
...
dist.macosx:
      [zip] Building zip: /Users/manuel/git/jitsi-videobridge/dist/macosx/jitsi-videobridge-macosx-build.SVN.zip

BUILD FAILED
/Users/manuel/git/jitsi-videobridge/build.xml:278: Problem creating zip: /Users/manuel/git/jitsi-videobridge/dist/macosx/jitsi-videobridge-macosx-build.SVN.zip (No such file or directory) (and the archive is probably corrupt but I could not delete it)
You can merge this Pull Request by running:

  git pull https://github.com/ApaxoGmbH/jitsi-videobridge master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-videobridge/pull/50

-- Commit Summary --

  * Fixed bug in ant script to create dist directory if it is not there:

-- File Changes --

    M build.xml (1)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/50.patch
https://github.com/jitsi/jitsi-videobridge/pull/50.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50


#2

Thanks for the contribution!

Do you have any idea why this is necessary? With ant 1.9.3 running on osx and ant 1.8.2 on linux the directory is created automatically it is needed. I was able to reproduce your error only by revoking write privileges on dist/macosx for the user running ant, and it doesn't look like the patch would solve this.

FWIW I am running into other errors if I either:
1. Make an empty dist/macosx/jitsi-videobridge-macosx-build.SVN.zip
2. Revoke write privileges on dist/macosx/jitsi-videobridge-macosx-build.SVN.zip
Both should be work-aroundable by removing the zip file beforehand.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#issuecomment-66716649


#3

Hi,
I would guess it is because I am running a quite old version of ant:

    $ ant -version
    Apache Ant version 1.7.1 compiled on June 27 2008

For all my projects I use maven. Especially the dependency management and the integration with continuous integration systems make it a reasonable choice for build management.

Hope that helps
    Manuel

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#issuecomment-66741902


#4

With ant 1.9.3 it works.

$ ant dist.macosx
Buildfile: /Users/manuel/git/jitsi-videobridge/build.xml

compile:
    [mkdir] Created dir: /Users/manuel/git/jitsi-videobridge/classes
    [javac] /Users/manuel/git/jitsi-videobridge/build.xml:90: warning: 'includeantruntime' was not set, defaulting to build.sysclasspath=last; set to false for repeatable builds
    [javac] Compiling 77 source files to /Users/manuel/git/jitsi-videobridge/classes
    [javac] warning: [options] bootstrap class path not set in conjunction with -source 1.5
    [javac] warning: [options] source value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] target value 1.5 is obsolete and will be removed in a future release
    [javac] warning: [options] To suppress warnings about obsolete options, use -Xlint:-options.
    [javac] Note: /Users/manuel/git/jitsi-videobridge/src/org/jitsi/videobridge/Videobridge.java uses or overrides a deprecated API.
    [javac] Note: Recompile with -Xlint:deprecation for details.
    [javac] 4 warnings

jar:
      [jar] Building jar: /Users/manuel/git/jitsi-videobridge/jitsi-videobridge.jar

make:

dist.macosx:
    [mkdir] Created dir: /Users/manuel/git/jitsi-videobridge/dist/macosx
      [zip] Building zip: /Users/manuel/git/jitsi-videobridge/dist/macosx/jitsi-videobridge-macosx-build.SVN.zip

BUILD SUCCESSFUL
Total time: 8 seconds
localhost:jitsi-videobridge manuel$ ant -version
Apache Ant(TM) version 1.9.3 compiled on December 23 2013
···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#issuecomment-66742329


#5

Before we accept your contribution we need you to sign our contributor agreement[1]. Apologies for the inconvenience, but unfortunately we cannot avoid it.

[1] http://bluejimp.com/bca.pdf

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#issuecomment-66882996


#6

Hi bgrozev,
I send a signed copy to:

contact@bluejimp.com

I hope that somebody can forward it to you.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#issuecomment-66884807


#7

Merged #50.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/50#event-208315750