[jitsi-dev] [jitsi-videobridge] Always generate a positive SSRC. (#127)


#1

Does not really fix anything, as the SSRC is converted to unsigned before being sent out (in SourcePacketExtension.setSSRC). However, this eases debugging and makes the code cleaner IMHO.

The same problem seems to exist in libjitsi:SSRCFactoryImpl.doGenerateSSRC, though.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/127

-- Commit Summary --

  * Always generate a positive SSRC.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Content.java (2)
    M src/main/java/org/jitsi/videobridge/RtpChannel.java (2)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/127.patch
https://github.com/jitsi/jitsi-videobridge/pull/127.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/127


#2

Thank you for the fix! Before merging, we need you to sign our contributor agreement ([individual](https://jitsi.org/icla) or [corporate](https://jitsi.org/ccla)).

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/127#issuecomment-178659811


#3

I just saw your other PR, I see the CLA. Thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/127#issuecomment-178664837


#4

Merged #127.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/127#event-536078677