[jitsi-dev] [jitsi-videobridge] Adds HealthCheckIQ handling to the Videobridge. (#139)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/139

-- Commit Summary --

  * Adds HealthCheckIQ handling to the Videobridge.

-- File Changes --

    M pom.xml (2)
    M src/main/java/org/jitsi/videobridge/Videobridge.java (43)
    R src/main/java/org/jitsi/videobridge/health/Health.java (14)
    M src/main/java/org/jitsi/videobridge/rest/HandlerImpl.java (1)
    M src/main/java/org/jitsi/videobridge/xmpp/ComponentImpl.java (79)
    M src/test/java/org/jitsi/videobridge/FocusControlTest.java (31)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/139.patch
https://github.com/jitsi/jitsi-videobridge/pull/139.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/139


#2

Merged #139.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/139#event-557012873


#3

@paweldomas, as we talked in person, there's the following problem with the tests (which I don't think is related to the modifications introduced by this PR):

I have org.jitsi.videobridge.defaultOptions=3 in my ~/.sip-communicator/sip-communicator.properties. It causes the following test failures:

focusControlTest(org.jitsi.videobridge.FocusControlTest) Time elapsed: 32.425 sec <<< FAILURE!
java.lang.AssertionError: expected null, but was:<net.java.sip.communicator.impl.protocol.jabber.extensions.colibri.ColibriConferenceIQ@3c1>
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotNull(Assert.java:664)
  at org.junit.Assert.assertNull(Assert.java:646)
  at org.junit.Assert.assertNull(Assert.java:656)
  at org.jitsi.videobridge.FocusControlTest.focusControlTest(FocusControlTest.java:136)

authorizedSourceTest(org.jitsi.videobridge.FocusControlTest) Time elapsed: 0.004 sec <<< FAILURE!
java.lang.AssertionError: expected:<result> but was:<error>
  at org.junit.Assert.fail(Assert.java:88)
  at org.junit.Assert.failNotEquals(Assert.java:743)
  at org.junit.Assert.assertEquals(Assert.java:118)
  at org.junit.Assert.assertEquals(Assert.java:144)
  at org.jitsi.videobridge.FocusControlTest.expectResult(FocusControlTest.java:73)
  at org.jitsi.videobridge.FocusControlTest.authorizedSourceTest(FocusControlTest.java:211)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/139#issuecomment-186374138


#4

The issue mentioned above has been addressed here:
https://github.com/jitsi/jitsi-videobridge/commit/d40f2a107b79e841762d845794e0e577dbc31ed0

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/139#issuecomment-186376048