[jitsi-dev] [jitsi-videobridge] Adding capability to read JVM options from an external rc file (#35)


#1

I would like to set some options of the java process from an external config file.
The rc file seemed to be a more elegant solution for these options than the command line parameters.
The memory limit could be calculated based on the total memory of the server in the rc file.

There was no memory limit in the 32 bit linux and the osx jvb.sh files so I didn't apply the limit on those architectures.

You can merge this Pull Request by running:

  git pull https://github.com/varrocs/jitsi-videobridge master

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-videobridge/pull/35

-- Commit Summary --

  * Adding capability to read JVM options from an external rc file

-- File Changes --

    A lib/videobridge.rc (8)
    M resources/install/linux-64/jvb.sh (9)
    M resources/install/linux/jvb.sh (8)
    M resources/install/macosx/jvb.sh (8)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/35.patch
https://github.com/jitsi/jitsi-videobridge/pull/35.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/35


#2

lgtm

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/35#issuecomment-63050061


#3

Merged #35.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/35#event-193321856