[jitsi-dev] [jitsi-videobridge] Added prevention of unclosed ice sockets (#44)


#1

Added close for ice sockets when getting both TCP and UDP StreamConnectors if the sockets are not of MultiplexingSocket or MultiplexingDatagramSocket type. Closed possibly unclosed resources.
You can merge this Pull Request by running:

  git pull https://github.com/mondain/jitsi-videobridge patch-2

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-videobridge/pull/44

-- Commit Summary --

  * Added prevention of unclosed ice sockets

-- File Changes --

    M src/org/jitsi/videobridge/IceUdpTransportManager.java (23)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/44.patch
https://github.com/jitsi/jitsi-videobridge/pull/44.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44


#2

Thank you for the contribution! Before you accept it, we need you to sign the contributor agreement[1].

[1] http://bluejimp.com/bca.pdf

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44#issuecomment-65448298


#3

With regards to the actual pr: If the sockets aren't Multiplexing*Socket there would be severe problems. We should also log an error.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44#issuecomment-65448552


#4

Already signed and sent agreement previously.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44#issuecomment-65450689


#5

Can one of the admins verify this patch?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44#issuecomment-192016179


#6

Closed #44.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/44#event-1335118090