[jitsi-dev] [jitsi-videobridge] add json escape; test with endpoint=foo\ bar@host (#33)


#1

whoops, pushed to the wrong remote master. Anyway... haven't deployed that yet, need to do so before merging.

It seems that endpoints like "foo\ bar@host/resource" make the current code generate invalid JSON for dominant speaker events.
You can merge this Pull Request by running:

  git pull https://github.com/jitsi/jitsi-videobridge fix-json

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi-videobridge/pull/33

-- Commit Summary --

  * add json escape; test with endpoint=foo\ bar@host

-- File Changes --

    M src/org/jitsi/videobridge/Conference.java (4)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/33.patch
https://github.com/jitsi/jitsi-videobridge/pull/33.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33


#2

@gpolitis can you take a look please? I think the simulcast messages properly escape in that case.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33#issuecomment-61967616


#3

commit c7f1e9317ac89c1b487778c10bdb924c29e6de6e

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33#issuecomment-61968356


#4

Closed #33.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33#event-189261273


#5

@fippo yes they are, thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33#issuecomment-61968581


#6

testing actually needs to be done with "foo\20bar@host" since that is how we do JID escaping in XMPP. But it works nonetheless. Thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/33#issuecomment-61971251