[jitsi-dev] [jitsi] Use string comparison instead of int comparison (#240)


#1

Currently if the architecture is defined differently (such
as 'amd64' used in NetBSD), this comparison fails with:
[: amd64: bad number
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/240

-- Commit Summary --

  * Use string comparison instead of int comparison

-- File Changes --

    M resources/install/generic/run.sh (2)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/240.patch
https://github.com/jitsi/jitsi/pull/240.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/240


#2

This appears elsewhere for Debian and Linux, it might be worth fixing those too, in case someone wants to build for architectures other than Intel ones.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/240#issuecomment-199500398


#3

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/240#issuecomment-218825983


#4

Done

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/240#issuecomment-218841184


#5

Merged #240.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/240#event-663492161