[jitsi-dev] [jitsi] Support for HA PBX (#154)


#1

Added Checkbox to enable "FORCE_PROXY_BYPASS"
This disable the filter function of SIP Proxys that are not the current used proxy.
If you use Jitsi with a HA PBX like sipXcom you can get SIP Messages from Multiple Proxys.

Default value is "false" to ensure security on non-HA scenarios.

See JITSI-1105 or http://lists.jitsi.org/pipermail/users/2013-January/001215.html
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi/pull/154

-- Commit Summary --

  * Added abbility to set option FORCE_PROXY_BYPASS via SipAccount
  * Added additional check for proxy filter by address.
  * fixed wrongly changed code refactorins
  * Fixed copy paste error. Now FORCE_PROXY_BYPASS works as expected.

-- File Changes --

    M resources/languages/resources.properties (1)
    M resources/languages/resources_de.properties (1)
    M src/net/java/sip/communicator/impl/protocol/sip/SipStackSharing.java (10)
    M src/net/java/sip/communicator/plugin/sipaccregwizz/ConnectionPanel.java (54)
    M src/net/java/sip/communicator/plugin/sipaccregwizz/SIPAccountRegistrationForm.java (6)
    M src/net/java/sip/communicator/service/protocol/sip/SipAccountID.java (21)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/154.patch
https://github.com/jitsi/jitsi/pull/154.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154


#2

Our CEO has to sign CLA first.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154#issuecomment-142640648


#3

@@ -1174,6 +1174,7 @@ plugin.sipaccregwizz.PREFERRED_TRANSPORT=Bevorzugter Transport
plugin.sipaccregwizz.ADVANCED_OPTIONS=Erweiterte Optionen
plugin.sipaccregwizz.PROXY_OPTIONS=Proxy-Server-Optionen
plugin.sipaccregwizz.PROXY_AUTO=Proxy-Server automatisch konfigurieren
+plugin.sipaccregwizz.PROXY_FORCE_BYPASS=Proxy überprüfungs Umgehung (für HA Szenarien)

Please don't change individual language files, they'll get overwritten from [Pootle](http://translate.jitsi.org)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41098975


#4

@@ -1031,7 +1031,15 @@ private void filterByAddress(
         while (iterPP.hasNext())
         {
             ProtocolProviderServiceSipImpl candidate = iterPP.next();
-
+ boolean forceProxyBypass
+ = candidate.getAccountID()
+ .getAccountPropertyBoolean(
+ ProtocolProviderFactory.FORCE_PROXY_BYPASS, false);
+ if(forceProxyBypass)
+ {
+ // Proxy check is disabled all connections are ok (HA sipXecs, sipXcom, ...)

Please wrap at 80 chars.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41098980


#5

@@ -826,6 +854,28 @@ void enablesProxyAutoConfigure(boolean isEnable)
     }

     /**
+ * Indicates if the proxy force bypass-configure is enabled.
+ * * @return <tt>true</tt> if the proxy force bypass-configuration is enabled,
+ * <tt>false</tt> - otherwise
+ */

This formatting somehow went wrong.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41099009


#6

@@ -428,6 +433,7 @@ public void loadAccount(SIPAccountRegistration sipAccReg)
         connectionPanel.setCertificateId(clientTlsCertificateId);

         connectionPanel.enablesProxyAutoConfigure(proxyAutoConfigureEnabled);
+ connectionPanel.enablesProxyForceBypassConfigure(proxyForceBypassConfigureEnabled);

80 chars wrap

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41099013


#7

@@ -382,6 +385,8 @@ public void loadAccount(SIPAccountRegistration sipAccReg)
         String clientTlsCertificateId = sipAccReg.getTlsClientCertificate();

         boolean proxyAutoConfigureEnabled = sipAccReg.isProxyAutoConfigure();
+
+ boolean proxyForceBypassConfigureEnabled = sipAccReg.isProxyForceBypassConfigure();

80 chars wrap

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41099015


#8

@@ -1232,6 +1232,7 @@ plugin.sipaccregwizz.PREFERRED_TRANSPORT=Preferred transport
plugin.sipaccregwizz.ADVANCED_OPTIONS=Advanced options
plugin.sipaccregwizz.PROXY_OPTIONS=Proxy options
plugin.sipaccregwizz.PROXY_AUTO=Configure proxy automatically
+plugin.sipaccregwizz.PROXY_FORCE_BYPASS=Configure force proxy bypass (for HA scenarios)

I'm inclined to name this something like "Bypass proxy security check for HA scenarios". The point in including the term "security" is to raise an awareness that this should not be enabled just because HA sounds cool.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154/files#r41099034


#9

Thanks for your feedback. I'll solve this and reporte back when it is done.

Sorry for the line wrappings. At end I've forgotten to check.

Regards
Claas

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154#issuecomment-145501690


#10

Ok I think I've found all problems and solved it.
@ibauersachs Could you check again please? Feel free to comment or give feedback. Hope this fits to your rules. :slight_smile:

Regards,
Claas

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154#issuecomment-145531229


#11

Merged #154.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154#event-427047820


#12

All good now, thanks!

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/154#issuecomment-145604579