[jitsi-dev] [jitsi] Sip uri on boot (#49)


#1

I've observed the following on startup when dialing a URI from the command line:

* Jitsi displays an error saying that the user is not registered, asking if the user wants to register
* Whatever choice the user makes, a second error popup is displayed saying the call fails
* If the user clicks to register, the call is not attempted

This makes it more likely that the call will proceed

It also eliminates the second popup if the user clicks Yes in the first popup

You can merge this Pull Request by running:

  git pull https://github.com/dpocock/jitsi sip-uri-on-boot

Or you can view, comment on it, or merge it online at:

  https://github.com/jitsi/jitsi/pull/49

-- Commit Summary --

  * Avoid showing error popup if user clicks Yes in registration popup
  * Try to register more aggressively when dialing a URI on startup

-- File Changes --

    M src/net/java/sip/communicator/impl/protocol/sip/UriHandlerSipImpl.java (23)

-- Patch Links --

https://github.com/jitsi/jitsi/pull/49.patch
https://github.com/jitsi/jitsi/pull/49.diff

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49


#2

Hmm. This changes the behavior so that the account is always attempted to register first. If an account is intentionally offline, this shouldn't be done. I'd be okay with retrying a couple of times before giving up and the second change with hiding the error if the user chose to register.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-51629254


#3

Thanks for the feedback, I've adapted this change (see the new commits) so it doesn't try to force the registration/online state, it just waits politely to see if it comes online within 2 seconds. This eliminates the various popups that appear if it tries to dial too quickly. If it still isn't online after 2 seconds then the existing behavior is the same.
https://trac.jitsi.org/ticket/1301

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-51686401


#4

Instead of polling, can you please use PPS.add/remoteRegistrationStateChangeListener(...) with a timeout?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-52029735


#5

Ingo, I understand that may be a more elegant solution but do you feel the code in the current pull request is an improvement over the problem we have right now? If the pull request improves the code (by eliminating the error popups and ensuring that it can dial a URI immediately on startup) without introducing any other flaw that is more serious than the problem I have tried to solve then would you consider accepting it as is?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-52039159


#6

Personally, I prefer a big bug (popups) over a small one (resource usage), because the small one will never be fixed. I was able to fetch a git installation now and hacked ibauersachs/jitsi@9483d111ef4fd118f1d9f98be2899a6b837e5409. Can you give that a try please?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-52073405


#7

@ibauersachs thanks for that - I've updated it as we discussed and tested it, appears to be working for me, popups don't appear. The default timeout is increased to 5 seconds now too.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-53040964


#8

Merged #49.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#event-156077817


#9

Thanks for the help with this, could you merge the latest master into the webstart branch again?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/pull/49#issuecomment-53151207