[jitsi-dev] [jitsi] "Share Desktop" button is always shown regardless of functionality (#186)


#1

The "Share Desktop" button always shows up, although it should only be displayed if this contact supports Jingle. If the other contact is not running such a client it will always fail. Jingle is also needed for calling and this call button is shown appropriately. So showing the "Share Desktop" button **without** the call button should be a contradiction. I mentioned the bug [here](http://lists.jitsi.org/pipermail/users/2015-October/010175.html).

I suspect the bug could be [here](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetContactCapabilitiesJabberImpl.java#L242) or rather in those classes [here](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetDesktopStreamingJabberImpl.java), [here](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetDesktopSharingServerJabberImpl.java) or maybe [here](https://github.com/jitsi/jitsi/blob/master/src/net/java/sip/communicator/impl/protocol/jabber/OperationSetDesktopSharingClientJabberImpl.java).

![screen shot 2015-11-15 at 03 01 53](https://cloud.githubusercontent.com/assets/11325631/11166790/5980f69e-8b46-11e5-87f1-3bcd5a07f717.png)

![screen shot 2015-11-15 at 03 01 35](https://cloud.githubusercontent.com/assets/11325631/11166789/597ec64e-8b46-11e5-877a-8807110cae33.png)

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/186


#2

Closed #186 via ad61332a3e000d30fd3a2c24d2d3c6f1430f4c46.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/186#event-665046640