[jitsi-dev] [jitsi] reserved identifier violation (#157)


#1

I would like to point out that identifiers like "[`_Image`](https://github.com/jitsi/jitsi/blob/4b124d7b8a79739686aac64450b2ba390217087e/src/native/linux/galagonotification/net_java_sip_communicator_impl_galagonotification_GalagoNotification.c#L24)" and "[`_Included_net_java_sip_communicator_impl_hid_NativeKeyboard`](https://github.com/jitsi/jitsi/blob/6a67589c86221faedcebd370824274013be64026/src/native/hid/net_java_sip_communicator_impl_hid_NativeKeyboard.h#L5)" [do not fit](https://www.securecoding.cert.org/confluence/display/cplusplus/DCL51-CPP.+Do+not+declare+or+define+a+reserved+identifier "Do not use identifiers that are reserved for the compiler implementation.") to the expected naming convention of the C++ language standard.
Would you like to adjust your selection for unique names?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/157


#2

I'm open for a pull request about the _Image identifier. The inclusion thing is from generated code (javah), so this isn't something to change (unless Oracle changed the output of javah).

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/157#issuecomment-145365749


#3

How do you think about to achieve corresponding improvements also for a tool like "javah"?

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/157#issuecomment-145531728


#4

javah is from Oracle's JDK, [file (or find)](https://bugs.openjdk.java.net) a bug report there. AFAIK the [ceph](http://tracker.ceph.com/issues/98#change-469) project already mentioned that to you five years ago.

···

---
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi/issues/157#issuecomment-145535758