[jitsi-dev] jitsi-meet: when focus user is renamed, TypeError occurs in web client after joining conference

#1

Hello,

In jitsi-meet's default config.js the following line is present:

    //focusUserJid: 'focus@auth.jitsi-meet.example.com', // The real JID
of focus participant - can be overridden here

However if the JID is changed to something else, such as
'thefocus@example.com' the following error occurs in the web client
after the user joins the conference:

function () - error - TypeError: remoteVideos[resourceJid] is
undefined

Also, the large video area does not show the user's video on joining the
conference. Nor is the user granted moderator privileges.

It appears that in two places client code extracts the first part of the
JID and compares it to the literal string 'focus'.

Updating modules/UI/videolayout/VideoLayout.js to use member.isFocus
instead of doing a string comparison causes the error to go away, the
video to show on joining, and the user to be granted moderator
privileges.

Example fix:
https://github.com/bickelj/jitsi-meet/commit/806cacb755044c8f635fcffb2c4f9fee00bd5bc7

(The other spot is modules/xmpp/moderator.js, in this case it didn't
seem as obvious how to fix it).

Should I submit a pull request of the above commit?

Jesse

#2

Hello, i don't know if i am in the good place to ask for a request

it will be nice to have an option "number of thumbnail" (config.js) in the film strip (0 for unlimited thumbnail)

for exemple now i am using channelLastN: 4 (it only show 4 thumbnails)

with a new option i can set
channelLastN: 4
number of thumbnail : 10

so it will show 10 thunbnails (4videos, 6 avatars)
like this you can see that there is people and it will be easier to moderate (mute, etc) (even if we see only avatar)

it will give more life than only a few thumbnail

#3

I created https://github.com/jitsi/jitsi-meet/pull/361 in case you get a
few minutes to review and merge. Let me know if there is a different
process to follow (or any other feedback).

Cheers,

Jesse

···

On Fri, 2015-09-25 at 09:46 -0500, Jesse wrote:

Hello,

In jitsi-meet's default config.js the following line is present:

    //focusUserJid: 'focus@auth.jitsi-meet.example.com', // The real JID
of focus participant - can be overridden here

However if the JID is changed to something else, such as
'thefocus@example.com' the following error occurs in the web client
after the user joins the conference:

function () - error - TypeError: remoteVideos[resourceJid] is
undefined

Also, the large video area does not show the user's video on joining the
conference. Nor is the user granted moderator privileges.

It appears that in two places client code extracts the first part of the
JID and compares it to the literal string 'focus'.

Updating modules/UI/videolayout/VideoLayout.js to use member.isFocus
instead of doing a string comparison causes the error to go away, the
video to show on joining, and the user to be granted moderator
privileges.

Example fix:
https://github.com/bickelj/jitsi-meet/commit/806cacb755044c8f635fcffb2c4f9fee00bd5bc7

(The other spot is modules/xmpp/moderator.js, in this case it didn't
seem as obvious how to fix it).

Should I submit a pull request of the above commit?

Jesse