[jitsi-dev] jitsi-meet: Defects in nickname handling


#1

Hi,

I wasn’t sure how to provide some bug fixes concerning the latest commit [4bb555e] of jitsi-meet app.

There are some typos in the new nicknamehandler and the issue that a stored nickname/displayname does not appear when starting up.

in modules/UI/util/NicknameHandler.js:
line 6:
-var NickanameHandler = {
+var NicknameHandler = {

line 30:
-module.exports = NickanameHandler;
+module.exports = NicknameHandler;

in modules/UI/videolayout/Videolayout.js:
line 551:
- setDisplayName('localVideoContainer');
+ setDisplayName('localVideoContainer', NicknameHandler.getNickname() + ' (me)‘);

BR
Thomas


#2

Another major one - prohibits the proper display of the peer nick name:

in app.js:
line 22:
- APP.xmpp.start(APP.UI.getCreadentials);
+ APP.xmpp.start(APP.UI.getCredentials());

Fix also getCredentials in UI.js (instead of getCreadentials )

···

Am 31.01.2015 um 11:53 schrieb Thomas Odorfer <odotom@gmail.com>:

Hi,

I wasn’t sure how to provide some bug fixes concerning the latest commit [4bb555e] of jitsi-meet app.

There are some typos in the new nicknamehandler and the issue that a stored nickname/displayname does not appear when starting up.

in modules/UI/util/NicknameHandler.js:
line 6:
-var NickanameHandler = {
+var NicknameHandler = {

line 30:
-module.exports = NickanameHandler;
+module.exports = NicknameHandler;

in modules/UI/videolayout/Videolayout.js:
line 551:
- setDisplayName('localVideoContainer');
+ setDisplayName('localVideoContainer', NicknameHandler.getNickname() + ' (me)‘);

BR
Thomas