There are a couple of issues, which is why I think that using callbacks might be indeed the better way to go: JSON.stringify doesn’t handle circular structures well, such as events or strophe messages. I’ve worked around that by replacing the circular references, but that feels more like a hack.
Regards,
Nicholas
···
On 22 Oct 2014, at 13:13, Hristo Terezov <hristo@jitsi.org> wrote:
Hello,
Boris, yes it does toggle. I’ll rename it. Thanks for the report.
Nicholas, good idea. Emil proposed this too and maybe we will add it the next versions of the API.
Philipp, do you mean to add callbacks for the execution of the commands?
Thank you for the implementation. But I think we need to implement limited number of events like join and left a conference, not all that are currently triggered. So if we support limited number of events we can pass object using JSON.stringify that doesn’t have circular dependancies.
I’m not sure what do you mean by using callbacks. Is it the same as the approach described above?
There are a couple of issues, which is why I think that using callbacks might be indeed the better way to go: JSON.stringify doesn’t handle circular structures well, such as events or strophe messages. I’ve worked around that by replacing the circular references, but that feels more like a hack.
Regards,
Nicholas
On 22 Oct 2014, at 13:13, Hristo Terezov <hristo@jitsi.org> wrote:
Hello,
Boris, yes it does toggle. I’ll rename it. Thanks for the report.
Nicholas, good idea. Emil proposed this too and maybe we will add it the next versions of the API.
Philipp, do you mean to add callbacks for the execution of the commands?
definitely. For an API it makes more sense to have a stable set of events that apps can register to and in that case we don’t have the issue with circular dependencies.
Yes, I think I’m talking about the same approach as Philipp. I don’t have a fixed implementation strategy in mind, though.
Regards,
Nicholas
···
On 23 Oct 2014, at 11:07, Hristo Terezov <hristo@jitsi.org> wrote:
Hi Nicholas,
Thank you for the implementation. But I think we need to implement limited number of events like join and left a conference, not all that are currently triggered. So if we support limited number of events we can pass object using JSON.stringify that doesn’t have circular dependancies.
I’m not sure what do you mean by using callbacks. Is it the same as the approach described above?
There are a couple of issues, which is why I think that using callbacks might be indeed the better way to go: JSON.stringify doesn’t handle circular structures well, such as events or strophe messages. I’ve worked around that by replacing the circular references, but that feels more like a hack.
conferenceCreated - conference id
recordingStarted - directory
recordingStopped - /
What do you think? I would create a pull request for these events.
Cheers,
Nicholas
···
On 23 Oct 2014, at 11:07, Hristo Terezov <hristo@jitsi.org> wrote:
Hi Nicholas,
Thank you for the implementation. But I think we need to implement limited number of events like join and left a conference, not all that are currently triggered. So if we support limited number of events we can pass object using JSON.stringify that doesn’t have circular dependancies.
I’m not sure what do you mean by using callbacks. Is it the same as the approach described above?
There are a couple of issues, which is why I think that using callbacks might be indeed the better way to go: JSON.stringify doesn’t handle circular structures well, such as events or strophe messages. I’ve worked around that by replacing the circular references, but that feels more like a hack.
OK ... except maybe for the directory since that might reveal sensitive information. I think we may want to add a publicly accessible URL though and send that in deployments that allow for it.
recordingStopped - /
OK.
Emil
···
On 8.11.14, 15:50, Nicholas Wittstruck wrote:
What do you think? I would create a pull request for these events.
Thank you for the implementation. But I think we need to implement
limited number of events like join and left a conference, not all that
are currently triggered. So if we support limited number of events we
can pass object using JSON.stringify that doesn�t have circular
dependancies.
I�m not sure what do you mean by using callbacks. Is it the same as
the approach described above?
There are a couple of issues, which is why I think that using
callbacks might be indeed the better way to go: JSON.stringify
doesn�t handle circular structures well, such as events or strophe
messages. I�ve worked around that by replacing the circular
references, but that feels more like a hack.
I would see this triggered on the conferenceCreated.jingle event. This is when the focus receives the conference id, which is needed to query the rest api of the videobridge. I am aware that this event is only triggered for the focus.
recordingStarted - directory
OK ... except maybe for the directory since that might reveal sensitive information. I think we may want to add a publicly accessible URL though and send that in deployments that allow for it.
I’ve already removed the path from the response of the videobridge, which contains information about the storage setup. The directory itself does not hold a lot of sensitive information, since it is generated by jitsi and just contains a timestamp and the conference id (which is available on the client side anyway). A publicly accessible URL would be nice, though. I could add this in a second step.
Cheers
Nicholas
···
On 08 Nov 2014, at 15:56, Emil Ivov <emcho@jitsi.org> wrote:
On 8.11.14, 15:50, Nicholas Wittstruck wrote:
recordingStopped - /
OK.
Emil
What do you think? I would create a pull request for these events.
Thank you for the implementation. But I think we need to implement
limited number of events like join and left a conference, not all that
are currently triggered. So if we support limited number of events we
can pass object using JSON.stringify that doesn’t have circular
dependancies.
I’m not sure what do you mean by using callbacks. Is it the same as
the approach described above?
There are a couple of issues, which is why I think that using
callbacks might be indeed the better way to go: JSON.stringify
doesn’t handle circular structures well, such as events or strophe
messages. I’ve worked around that by replacing the circular
references, but that feels more like a hack.
On 08 Nov 2014, at 15:56, Emil Ivov <emcho@jitsi.org> wrote:
Hey Nicholas,
On 8.11.14, 15:50, Nicholas Wittstruck wrote:
Hi Hristo,
I would like to propose the following events:
conferenceCreated - conference id
Hmmm ... when would you see this being triggered?
I would see this triggered on the conferenceCreated.jingle event. This is when the focus receives the conference id, which is needed to query the rest api of the videobridge. I am aware that this event is only triggered for the focus.
recordingStarted - directory
OK ... except maybe for the directory since that might reveal sensitive information. I think we may want to add a publicly accessible URL though and send that in deployments that allow for it.
I’ve already removed the path from the response of the videobridge, which contains information about the storage setup. The directory itself does not hold a lot of sensitive information, since it is generated by jitsi and just contains a timestamp and the conference id (which is available on the client side anyway). A publicly accessible URL would be nice, though. I could add this in a second step.
Cheers
Nicholas
recordingStopped - /
OK.
Emil
What do you think? I would create a pull request for these events.
Thank you for the implementation. But I think we need to implement
limited number of events like join and left a conference, not all that
are currently triggered. So if we support limited number of events we
can pass object using JSON.stringify that doesn’t have circular
dependancies.
I’m not sure what do you mean by using callbacks. Is it the same as
the approach described above?
There are a couple of issues, which is why I think that using
callbacks might be indeed the better way to go: JSON.stringify
doesn’t handle circular structures well, such as events or strophe
messages. I’ve worked around that by replacing the circular
references, but that feels more like a hack.