[jitsi-dev] Jitsi logging disable


#1

I try to make patch so disabling of log works. If I understund right, this
option is at config dialog but it's not do work and it does not save it's
state on exit. This, as I am thinking, need to be fixed.

But I have question.

Why net.java.sip.communicator.utils contains ConfiguratorUtils while there
is generalconfig plugin?

Gints


#2

I try to make patch so disabling of log works. If I understund right, this
option is at config dialog but it's not do work and it does not save it's
state on exit. This, as I am thinking, need to be fixed.

Of course, thanks for looking at it!

But I have question.

Why net.java.sip.communicator.utils contains ConfiguratorUtils while there

is

generalconfig plugin?

The ConfigurationUtils is a wrapper to access certain properties in a typed
way, while the generalconfig-plugin is just the UI to edit certain settings.

The problem in the end is that the history service acts on the property
"impl.msghistory.IS_MESSAGE_HISTORY_ENABLED", while parts of the
ConfigurationUtils act on
"net.java.sip.communicator.impl.gui.isHistoryLoggingEnabled". This needs to
be unified, but I'm currently not happy with either of them, IMO it should
be net.java.sip.communicator.impl.gui. IS_MESSAGE_HISTORY_ENABLED. That
would break a bit of compatibility with older versions, but as the setting
is broken anyway (from a UI perspective at least), I guess we can change it.

Yana, Emil?

Gints

Ingo


#3

Litle bit "dirty" way probably. But this way I can swtich log messeges off
and setting is kept on configuration after restart.

history.patch (7.77 KB)

···

2013/1/20 Ingo Bauersachs <ingo@jitsi.org>

net.java.sip.communicator.impl.gui. IS_MESSAGE_HISTORY_ENABLED

--
Gints


#4

Lol... actual way patch was removed by list. What would be correct way to
submit changes/patch?

···

2013/1/20 Gints Polis <polis.gints@gmail.com>

2013/1/20 Ingo Bauersachs <ingo@jitsi.org>

net.java.sip.communicator.impl.gui. IS_MESSAGE_HISTORY_ENABLED

Litle bit "dirty" way probably. But this way I can swtich log messeges off
and setting is kept on configuration after restart.

--
Gints

--
Ginc


#5

Thanks for the patch. I'll look into it.

Other devs: Currently the history logger checks his setting only on startup.
Either we add a note to the UI that a change of the history-settings
requires a restart or we make the history-service listen to that property.
Suggestion?
Oh, and which property-name do we agree on?

Ingo

···

-----Original Message-----
From: Gints Polis [mailto:polis.gints@gmail.com]
Sent: Sonntag, 20. Januar 2013 09:31
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Jitsi logging disable

2013/1/20 Ingo Bauersachs <ingo@jitsi.org>

  net.java.sip.communicator.impl.gui. IS_MESSAGE_HISTORY_ENABLED

Litle bit "dirty" way probably. But this way I can swtich log messeges off
and setting is kept on configuration after restart.

--
Gints


#6

Gints Polis:

Lol... actual way patch was removed by list.

No, it was not removed. I received it.

Cheers,
Andreas


#7

Hi,

maybe on startup we check for both to keep working current settings of
users, and from now on saving only the one which looks ok.

Regards
damencho

···

On Tue, Jan 22, 2013 at 10:39 AM, Ingo Bauersachs <ingo@jitsi.org> wrote:

Thanks for the patch. I'll look into it.

Other devs: Currently the history logger checks his setting only on startup.
Either we add a note to the UI that a change of the history-settings
requires a restart or we make the history-service listen to that property.
Suggestion?
Oh, and which property-name do we agree on?

Ingo

-----Original Message-----
From: Gints Polis [mailto:polis.gints@gmail.com]
Sent: Sonntag, 20. Januar 2013 09:31
To: dev@jitsi.java.net
Subject: [jitsi-dev] Re: Jitsi logging disable

2013/1/20 Ingo Bauersachs <ingo@jitsi.org>

      net.java.sip.communicator.impl.gui. IS_MESSAGE_HISTORY_ENABLED

Litle bit "dirty" way probably. But this way I can swtich log messeges off
and setting is kept on configuration after restart.

--
Gints


#8

maybe on startup we check for both to keep working current settings of
users, and from now on saving only the one which looks ok.

Neither of them is really ok...

Regards
damencho

Ingo


#9

IMHO it also stops logging right after you chek that check box.

···

2013/1/22 Ingo Bauersachs <ingo@jitsi.org>

> maybe on startup we check for both to keep working current settings of
> users, and from now on saving only the one which looks ok.

Neither of them is really ok...

> Regards
> damencho

Ingo

--
Ginc


#10

I mean I made like history service listens to that setting.

Gints

···

2013/1/22 Gints Polis <polis.gints@gmail.com>

IMHO it also stops logging right after you chek that check box.

2013/1/22 Ingo Bauersachs <ingo@jitsi.org>

> maybe on startup we check for both to keep working current settings of
> users, and from now on saving only the one which looks ok.

Neither of them is really ok...

> Regards
> damencho

Ingo

--
Ginc

--
Ginc