[jitsi-dev] [jitsi/libjitsi] Use byte instead of int for the constant time comparison (#143)


#1

no need to expend byte into int each round

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/143

-- Commit Summary --

  * Use byte instead of int for the constant time comparison

-- File Changes --

    M src/org/jitsi/impl/neomedia/transform/srtp/SRTCPCryptoContext.java (2)
    M src/org/jitsi/impl/neomedia/transform/srtp/SRTPCryptoContext.java (2)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/143.patch
https://github.com/jitsi/libjitsi/pull/143.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/143


#2

forget about this, ```tempStore[i] ^ tagStore[i]``` gives an int, so keeping ```nonEqual``` as int is the way to go
http://docs.oracle.com/javase/specs/jls/se8/html/jls-5.html#jls-5.6.2

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/143#issuecomment-214649196


#3

Closed #143.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/143#event-641074471