[jitsi-dev] [jitsi/libjitsi] Rework getRoundTripDelay to reduce 'RTT computation may be wrong' (#152)


#1

If RTT is really small (<1ms, like in a test setup), we might
end up with negative ntprtd value, but less than 1ms, which
we can round to 0. This is normal because timeMs is System.currentTimeMillis(),
so the (im)precision is 1ms at best.

Signed-off-by: Etienne CHAMPETIER <champetier.etienne@gmail.com>
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/152

-- Commit Summary --

  * Rework getRoundTripDelay to reduce 'RTT computation may be wrong'

-- File Changes --

    M src/org/jitsi/impl/neomedia/MediaStreamStatsImpl.java (36)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/152.patch
https://github.com/jitsi/libjitsi/pull/152.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/152


#2

This has been bugging us for a while. Thank you, @champtar!

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/152#issuecomment-214479101


#3

Merged #152.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/152#event-640463853