[jitsi-dev] [jitsi/libjitsi] Not logging a packet should be a warning. (#153)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/153

-- Commit Summary --

  * Not logging a packet should be a warning.

-- File Changes --

    M src/org/jitsi/impl/neomedia/transform/DebugTransformEngine.java (16)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/153.patch
https://github.com/jitsi/libjitsi/pull/153.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/153


#2

This could lead to flooded logfiles and the messages aren't particularly helpful.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/153#issuecomment-214848391


#3

This transform engine is not enabled by default as it's mainly used for debugging. When it is enabled, you want to know whether or not a packet has been successfully logged or not.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/153#issuecomment-214866585


#4

Merged #153.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/153#event-642093797