[jitsi-dev] [jitsi/libjitsi] Less locking but also less unnecessary new objects. (#148)


#1

In response to @gpolitis and conversation [here](https://github.com/jitsi/libjitsi/pull/145/files/7cdebacba6539fab0a9ae8a2f715889223009ce9#r60075218)

I didn't see a quick and easy way to test this, but basic sanity checks seem to pass (e.g. the videobridge runs and serves video).
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/148

-- Commit Summary --

  * Less locking but also less unnecessary new objects.

-- File Changes --

    M src/org/jitsi/impl/neomedia/rtp/translator/RTCPFeedbackMessageSender.java (19)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/148.patch
https://github.com/jitsi/libjitsi/pull/148.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/148


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/148#issuecomment-211685217


#3

To keep modifications to a minimum you could have used ```kfRequester``` instead of ```keyframeRequester```, except that it looks ok for me.

Side note: this is ok because ```new KeyframeRequester(mediaSenderSSRC)``` has no side effect

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/148#issuecomment-211983694


#4

Merged #148.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/148#event-633961648