[jitsi-dev] [jitsi/libjitsi] Incorrect assignment in InterArrival.java hinders bwe (#212)


#1

Been tracking down some bad bwe in poor uplink scenarios (particularly with long delay links) and was finding that jvb wasn't reacting as well to delay as p2p in the same conditions. Was finally able to track it down to a c++->java porting error in InterArrival::computeDeltas. In that function the values for the current and previous timestamp groups are tracked, but when we start a new group and want to update the previous, it does an assignment...which is a copy in the c++ code but ends up being a reference assignment in java, so the 2 variables end up pointing to the same reference, so the timestamps always match. After fixing that I got an accurate bwe for the scenario I was testing. Will get a patch up.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/212


#2

Closed #212.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/212#event-861375851


#3

Thank you @brianh5, nice catch.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/issues/212#issuecomment-260999660