[jitsi-dev] [jitsi/libjitsi] Fixes for simple bugs found with FindBugs (#146)


#1

This is a collections of really simple fixes, that's why i'm not opening a PR for each
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/146

-- Commit Summary --

  * AudioNotifierServiceImpl: prevent ClassCastException in equals
  * Fix copy/paste error
  * Remove dead code
  * Do not use integral division
  * Avoid multiplication overflow in SKP_SMLALBB
  * Avoid some uneeded boxing/unboxing/object creation
  * Close InputStream from getSystemResourceAsStream()

-- File Changes --

    M src/org/jitsi/examples/AVReceive2.java (4)
    M src/org/jitsi/examples/AVTransmit2.java (4)
    M src/org/jitsi/impl/configuration/ConfigurationServiceImpl.java (9)
    M src/org/jitsi/impl/neomedia/codec/audio/ilbc/JavaDecoder.java (2)
    M src/org/jitsi/impl/neomedia/codec/audio/ilbc/JavaEncoder.java (2)
    M src/org/jitsi/impl/neomedia/codec/audio/silk/SigProcFIX.java (2)
    M src/org/jitsi/impl/neomedia/notify/AudioNotifierServiceImpl.java (2)
    M src/org/jitsi/impl/neomedia/recording/RecorderEventHandlerJSONImpl.java (2)
    M src/org/jitsi/impl/neomedia/rtcp/termination/strategies/FeedbackCacheProcessor.java (2)
    M src/org/jitsi/impl/neomedia/rtp/remotebitrateestimator/InterArrival.java (2)
    M src/org/jitsi/impl/neomedia/transform/zrtp/ZRTPTransformEngine.java (2)
    M src/org/jitsi/service/version/util/AbstractVersion.java (4)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/146.patch
https://github.com/jitsi/libjitsi/pull/146.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/146


#2

Merged #146.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/146#event-640542100