[jitsi-dev] [jitsi/libjitsi] Fix a Directshow crash (#159)


#1

See commit d431682be6e8857edec60c6b779fd5d34bd8d800 for the actual juice.

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/159

-- Commit Summary --

  * Enable compilation with MSVC
  * Remove unused JNI method
  * Prevent a crash when source doesn't provide the data expected
  * Set format on each source filter pin

-- File Changes --

    M lib/native/win32-x86-64/jndirectshow.dll (0)
    M lib/native/win32-x86/jndirectshow.dll (0)
    M src/native/windows/directshow/BasicSampleGrabberCB.h (4)
    M src/native/windows/directshow/DSCaptureDevice.cpp (130)
    M src/native/windows/directshow/DSCaptureDevice.h (9)
    M src/native/windows/directshow/DSManager.cpp (6)
    A src/native/windows/directshow/jndirectshow.sln (28)
    A src/native/windows/directshow/jndirectshow.vcxproj (170)
    A src/native/windows/directshow/jndirectshow.vcxproj.filters (60)
    M src/native/windows/directshow/org_jitsi_impl_neomedia_jmfext_media_protocol_directshow_DSCaptureDevice.cpp (16)
    M src/native/windows/directshow/org_jitsi_impl_neomedia_jmfext_media_protocol_directshow_DSFormat.cpp (5)
    A src/native/windows/directshow/qedit.h (96)
    M src/org/jitsi/impl/neomedia/jmfext/media/protocol/directshow/DirectShowStream.java (19)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/159.patch
https://github.com/jitsi/libjitsi/pull/159.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/159


#2

Jenkins: test this again

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/159#issuecomment-220106055


#3

Jenkins: test this please

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/159#issuecomment-220109433


#4

Merged #159.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/159#event-664797568