[jitsi-dev] [jitsi/libjitsi] Add DelayingTransformEngine (#155)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/libjitsi/pull/155

-- Commit Summary --

  * Add DelayingTransformEngine

-- File Changes --

    A src/org/jitsi/impl/neomedia/transform/delay/DelayingTransformEngine.java (91)

-- Patch Links --

https://github.com/jitsi/libjitsi/pull/155.patch
https://github.com/jitsi/libjitsi/pull/155.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/155


#2

https://docs.oracle.com/javase/7/docs/api/java/util/concurrent/DelayQueue.html
Just asking why a number of packet and not a time?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/155#issuecomment-217197426


#3

This is going to be used only for audio/video synchronisation tests(lip sync) where we will be delaying audio packets and then trying to see if the video has been delayed as well. We do not do any calculations based on this packet delay value. This way it's just easier and simpler.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/155#issuecomment-217198892


#4

@champtar I agree that using a DelayQueue is a better approach in general, but this solution is simpler and works for our use-case.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/155#issuecomment-217204512


#5

Merged #155.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/libjitsi/pull/155#event-651651039