[jitsi-dev] [jitsi/jitsi-videobridge] Updates callstats to 3.3.0 and add reports for packet loss. (#333)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/333

-- Commit Summary --

  * Updates callstats to 3.3.0 and add reports for packet loss.

-- File Changes --

    M pom.xml (2)
    M src/main/java/org/jitsi/videobridge/eventadmin/callstats/CallStatsConferenceStatsHandler.java (4)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/333.patch
https://github.com/jitsi/jitsi-videobridge/pull/333.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/333


#2

bgrozev commented on this pull request.

@@ -340,6 +340,9 @@ private void processChannelStats(RtpChannel channel)

                     = new ConferenceStatsBuilder()
                         .bytesSent(receiveStat.getBytes())
                         .packetsSent(receiveStat.getPackets())
+ .packetsLost(receiveStat.getPacketsLost())
+ .fractionalPacketLost(
+ receiveStat.getCurrentPacketsLost())

This seems weird -- I would expect fractionalPacketLost to expect a fraction (although I haven't checked) and we're reporting a number of packets.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/333#pullrequestreview-4810168


#3

Merged #333.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/333#event-832445058