[jitsi-dev] [jitsi/jitsi-videobridge] Update callstats.io authentication to support shared secret and public/private keys (#359)


#1

Support both shared secret and public/private keys.
If both are set, prefer shared secret (callstats.io default).
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/359

-- Commit Summary --

  * Update callstats.io authentication schemes

-- File Changes --

    M doc/callstats.md (7)
    M src/main/java/org/jitsi/videobridge/stats/CallStatsIOTransport.java (59)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/359.patch
https://github.com/jitsi/jitsi-videobridge/pull/359.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#issuecomment-259996101


#3

@karthinkbr82 @eljasala PTAL. Thanks @trustlix for the effort.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#issuecomment-260443955


#4

@trustlix pushed 1 commit.

7f2dd11 Prefer public/private keys over shared secret

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359/files/7a9507428962111bd91d7998639c4a379be33764..7f2dd11f4f8d8a13c628ca2809874a501a173b42


#5

Jenkins, test this please.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#issuecomment-260739800


#6

@vr000m @damencho regarding the CLA, I've already signed it a couple weeks ago.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#issuecomment-260746478


#7

Confirmed for the CLA (Jenkins has its own white list).

Jenkins: add to whitelist

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#issuecomment-260747335


#8

Merged #359.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/359#event-860076562