[jitsi-dev] [jitsi/jitsi-videobridge] Stream switching (#299)


#1

Sends keyframe requests preemptively when an endpoint becomes the dominant speaker, in anticipation of receivers selecting that endpoint.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/299

-- Commit Summary --

  * refactor: Makes RtpChannel#dominantSpeakerChanged protected.
  * docs: Marks a method and a field as deprecated.
  * feat: Requests keyframes preemptively when the dominant speaker changes.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/RtpChannel.java (9)
    M src/main/java/org/jitsi/videobridge/VideoChannel.java (159)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/299.patch
https://github.com/jitsi/jitsi-videobridge/pull/299.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/299


#2

last-n already has code for this i think, right? does that mean it needs to be removed from the last-n logic or else 2 idrs will get requested?

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/299#issuecomment-243206001


#3

RTCPFeedbackMessageSender manages the actual requests that are sent, and should take care of not sending them unless necessary.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/299#issuecomment-243207406


#4

Merged #299.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/299#event-771068348