[jitsi-dev] [jitsi/jitsi-videobridge] Sctp close fix (#382)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/382

-- Commit Summary --

  * style: Whitespace, braces.
  * fix: Keeps the SctpConnection alive when data is received.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/SctpConnection.java (26)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/382.patch
https://github.com/jitsi/jitsi-videobridge/pull/382.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382


#2

bbaldino commented on this pull request.

@@ -1127,7 +1129,11 @@ public void run()

                 if (send == null || send.length == 0)
                     continue;

- if(LOG_SCTP_PACKETS)
+ // We received data for the SCTP socket, this SctpConnection
+ // is still alive
+ touch(ActivityType.PAYLOAD);

to make sure i'm understanding this right...previously data channel messages weren't counting as channel activity? and the stun checks counting as channel activity is handled elsewhere i guess?

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382#pullrequestreview-14061746


#3

@bgrozev pushed 1 commit.

e194c56 mvn: Update ice4j.

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382/files/6064728ba42807a1a9b5a9fd507f7ec4fa8f8486..e194c560221f11f2bf44bf72f3a9f244c2f84cd2


#4

bgrozev commented on this pull request.

@@ -1127,7 +1129,11 @@ public void run()

                 if (send == null || send.length == 0)
                     continue;

- if(LOG_SCTP_PACKETS)
+ // We received data for the SCTP socket, this SctpConnection
+ // is still alive
+ touch(ActivityType.PAYLOAD);

Yeah, exactly: https://github.com/jitsi/jitsi-videobridge/blob/master/src/main/java/org/jitsi/videobridge/IceUdpTransportManager.java#L1591

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382


#5

paweldomas approved this pull request.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382#pullrequestreview-14068696


#6

@bgrozev pushed 1 commit.

bc4e0f0 doc: Note that there is a fall-through and it is intentional.

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382/files/e194c560221f11f2bf44bf72f3a9f244c2f84cd2..bc4e0f09ff50c382e392c8ce4216b297e0db87fb


#7

Merged #382.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/382#event-902522346