[jitsi-dev] [jitsi/jitsi-videobridge] Respect last-n when adding pinned endpoints... (#300)


#1

...to the list of forwarded endpoints.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/300

-- Commit Summary --

  * style: Note that an unused param is intentionally there.
  * style: Removes a superflous null check.
  * fix: Respect last-n when adding pinned endpoints...

-- File Changes --

    M src/main/java/org/jitsi/videobridge/LastNController.java (30)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/300.patch
https://github.com/jitsi/jitsi-videobridge/pull/300.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/300


#2

@bgrozev i'm curious, is there something that breaks by letting pin go beyond the last-n list? i know the call on what to do there has been a question for a while (let it go over or don't), and we don't currently use it, but it didn't seem like the worst thing to allow for an explicit override. was there something that finally pushed the decision to limit it no matter what?

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/300#issuecomment-243255247


#3

Not sure if there was something in particular that triggered a decision. We were thinking of how this will play with adaptive last N (or changes to last-n from the bridge), and this seemed like the correct decisions, since the bridge explicitly signals to the client which endpoints it is currently forwarding anyway.
Do you see a use-case where honoring the client's request is an advantage?

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/300#issuecomment-243257849


#4

@bgrozev basically just to allow the client to say "i know i told you a last-n of 3 when i joined, but now i'm telling you i want to pin 4 clients, trust me". no passionate feelings about it being one way or another right now, was just curious if there was a specific reason to limit it in case we ever tinker with letting a client go over--wanted to know if there's anything major relying on it.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/300#issuecomment-243272121


#5

Merged #300.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/300#event-773946735