[jitsi-dev] [jitsi/jitsi-videobridge] Property name constants should be publicly accessible. (#348)


#1

This is a fix for https://github.com/jitsi/jitsi-videobridge/issues/347

When using a constant to refer to a property, this is typically done to avoid typos and add configuration. Keeping such constants non-public is counterproductive, as it forces people to revert to manually typing the property name (and typically hides javadoc).

Constants that are used to store property names should be publicly accessible.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/348

-- Commit Summary --

  * Property name constants should be publicly accessible.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/HarvesterConfiguration.java (10)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/348.patch
https://github.com/jitsi/jitsi-videobridge/pull/348.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/348


#2

Thank you for all the contributions, @guusdk !

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/348#issuecomment-255790849


#3

Merged #348.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/348#event-834142768


#4

Thanks for all the merges @bgrozev !

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/348#issuecomment-255797356