[jitsi-dev] [jitsi/jitsi-videobridge] No recording for people who join after recording has started (#227)


#1

When someone joins a session which is recording, jetsi meet will not record his track.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227


#2

I have found and fixed this before, but cannot share a patch/PR until my employer sorts out licensing/contributor agreements.

The problem is that when new SSRCs are signalled over colibri, the mapping from SSRC to EndpointID is not added to the Synchronizer instance used by RecorderRtpImpl. I made some modifications to RtpChannel.setSources() that checks whether recording is enabled, and calls synchronizer.setEndpoint() for each new SSRC.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-212850098


#3

Okay. I hope those legal concerns will be addressed. In fot I hope the info you've given will help other developers to make a patch.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-212859959


#4

@gavllew is #215 solving the same problem?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-212866353


#5

No - it's similar, but that one's related to simulcast instead of recording.

Sorry, my description of the fix was more to help the experienced Jitsi developers, rather than expecting you to fix it yourself. It took me a good few hours to track down the cause, and I wanted to save save the next person some time. :slight_smile:

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-212889258


#6

Yes, I was aware of that :slight_smile:

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-212893009


#7

@gavllew any news on the legal stuff that would enable you to send a PR?

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-218429028


#8

No, sorry. I do re-raise it occasionally, but not much seems to happen, so I wouldn't hold my breath. :-/

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#issuecomment-218432869


#9

Closed #227 via f4948645155032240ae4f07084890e7a77bdad95.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/227#event-764554877