[jitsi-dev] [jitsi/jitsi-videobridge] logs: Uses a strudcured format for some of the log messages. (#379)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/379

-- Commit Summary --

  * logs: Uses a strudcured format for some of the log messages.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Channel.java (44)
    M src/main/java/org/jitsi/videobridge/Conference.java (96)
    M src/main/java/org/jitsi/videobridge/Content.java (78)
    M src/main/java/org/jitsi/videobridge/Endpoint.java (69)
    M src/main/java/org/jitsi/videobridge/IceUdpTransportManager.java (53)
    M src/main/java/org/jitsi/videobridge/RtpChannel.java (40)
    M src/main/java/org/jitsi/videobridge/SctpConnection.java (39)
    M src/main/java/org/jitsi/videobridge/VideoChannel.java (39)
    M src/main/java/org/jitsi/videobridge/Videobridge.java (24)
    M src/main/java/org/jitsi/videobridge/simulcast/SimulcastReceiver.java (48)
    M src/main/java/org/jitsi/videobridge/simulcast/SimulcastSender.java (62)
    M src/main/java/org/jitsi/videobridge/simulcast/sendmodes/RewritingSendMode.java (31)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/379.patch
https://github.com/jitsi/jitsi-videobridge/pull/379.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/379


#2

My only suggestion would be to expand the variable names in the logs instead of abbreviating them. So conf_id would be conference_id and ch_id would be channel_id etc. The advantage of expanding them to the full words is that they become pretty much self documenting and it removes any ambiguity as to what they refer to. They logging improvement will be a big help in debugging multiple conferences.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/379#issuecomment-268347568


#3

I tend to prefer the shorter names, but I would let it up to @bgrozev to make the final decision.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/379#issuecomment-268350946


#4

Yes, let's stick to shorter names. I'll add documentation later on.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/379#issuecomment-268353723


#5

Merged #379.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/379#event-900728783