[jitsi-dev] [jitsi/jitsi-videobridge] Last-N not working properly (#223)


#1

We have successfully installed the Jitsi enviroment,
Videobridge + Jicofo + JitsiMeet and quickly developed a sample application.

The whole thing seems to work, both JitsiMeet and our SampleApp can create a video conference for any number of users;

The only issue we can't figure out is that the 'channelLastN' attribute doesn't appear to work properly.

After setting up 'channelLastN:2' in the config.js, every participant can at most see 2 remote videos,
but the list of the visible remote streams is never updated:
the lastNchanged message is never received (actually it is only fired when a user joins or leaves the conference)
regardless of the message 'new dominant speaker:' being received by the videobridge.

Videobridge seems to send messages for the new dominant speaker but for the lastN active users changes.

PS:
we also installed the latest nightly videobridge build 4/18/2016

Does anyone has the same issue or some advice ???

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/223


#2

Can't tell for sure, but it's possible this is caused by the issue
addressed here: https://github.com/jitsi/jitsi-videobridge/pull/204 (this
fixes a problem where a change in the last-n, but not in the list of total
participants, can result in no last-n changed message sent).

···

On Tue, Apr 19, 2016 at 8:04 AM, pastissolo <notifications@github.com> wrote:

We have successfully installed the Jitsi enviroment,
Videobridge + Jicofo + JitsiMeet and quickly developed a sample
application.

The whole thing seems to work, both JitsiMeet and our SampleApp can create
a video conference for any number of users;

The only issue we can't figure out is that the 'channelLastN' attribute
doesn't appear to work properly.

After setting up 'channelLastN:2' in the config.js, every participant can
at most see 2 remote videos,
but the list of the visible remote streams is never updated:
the lastNchanged message is never received (actually it is only fired when
a user joins or leaves the conference)
regardless of the message 'new dominant speaker:' being received by the
videobridge.

Videobridge seems to send messages for the new dominant speaker but for
the lastN active users changes.

PS:
we also installed the latest nightly videobridge build 4/18/2016

Does anyone has the same issue or some advice ???


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
<https://github.com/jitsi/jitsi-videobridge/issues/223>

_______________________________________________
dev mailing list
dev@jitsi.org
Unsubscribe instructions and other list options:
http://lists.jitsi.org/mailman/listinfo/dev


#3

Yes,
the issue was solved by changing
  `` if (equalAsSets(conferenceSpeechActivityEndpoints, `endpointIds))`

back to

`` if `(conferenceSpeechActivityEndpoints.equals(endpointIds))`

in src/main/java/org/jitsi/videobridge/LastNController.java
as suggested in #198.

···

---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/223#issuecomment-214680904


#4

Closed #223.

···

---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/223#event-641507006


#5

Yes, we merged Brian's fix (#204), so this shouldn't happen on master anymore.

···

---
You are receiving this because you commented.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/issues/223#issuecomment-214751092