[jitsi-dev] [jitsi/jitsi-videobridge] Fixe for issue https://github.com/jitsi/jitsi-videobridge/issues/279 (#308)


#1

Guys, i am absolutely new to Java, this pull request is just a reference to what i was talking about in issue that i have opened: https://github.com/jitsi/jitsi-videobridge/issues/279. Please feel free to modify as needed.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/308

-- Commit Summary --

  * Overload getTransportManager
  * Pass initiator when creating transport

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Channel.java (2)
    M src/main/java/org/jitsi/videobridge/Conference.java (48)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/308.patch
https://github.com/jitsi/jitsi-videobridge/pull/308.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#issuecomment-245962871


#3

Hey @sarumjanuch, thank you for the contribution! This looks like a valid fix for an issue that we've had for a long time, but right now the PR seems incomplete. Can you please do the following:
1. Instead of creating a new getTransportManager() add a parameter to the existing getTransportManager(String, boolean) (and remove the FIXME)
2. getTransportManager(String) should pass some value, with a comment that it is unused when create=false
3. Use the parsed value of the 'initiator' field in Videobridge.java (lines 928 and 1070). In both places the value is available in the 'initiator' variable, assume "true" if it is null.
4. Sign our CLA as jenkins requested (or let me know how to find it, I don't currently see it in the list)

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#issuecomment-247437537


#4

Jenkins, add to whitelist.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#issuecomment-247437622


#5

@sarumjanuch pushed 1 commit.

0d21b14 Remove Overload

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308/files/9d444bd5f45d115c6e7f82525a5c37453fba844a..0d21b14ce769205fbdd77b254cc65daf023afbec


#6

@sarumjanuch pushed 1 commit.

9b5e087 Pass initiator to getTransportManager

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308/files/0d21b14ce769205fbdd77b254cc65daf023afbec..9b5e0871e28c00e8df0e02ec4c4bd113e1d85cdc


#7

Made changes, as you requested. Also did sign CLA, please confirm, that you have received it, or ping me at eugene@thirdlane.com I will send PDF to you.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#issuecomment-247489220


#8

Thank you!

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#issuecomment-247490199


#9

Merged #308.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/308#event-791527388