[jitsi-dev] [jitsi/jitsi-videobridge] Fix: Update last-n on dominant speaker change (#363)


#1

Clients were not receiving updates to the last-n endpoints when the
active speaker changed. Now, the LastNController for each
VideoChannel should be notified as active speaker updates and will
push out last-n change events, if necessary.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/363

-- Commit Summary --

  * Fix: Update last-n on dominant speaker change

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Conference.java (1)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/363.patch
https://github.com/jitsi/jitsi-videobridge/pull/363.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/363


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/363#issuecomment-261395083


#3

dazaar should be added to our CLA.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/363#issuecomment-262369537


#4

Thanks you for the contribution, @dazaar !

Jenkins, ok to test

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/363#issuecomment-262547631


#5

Merged #363.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/363#event-869910434