[jitsi-dev] [jitsi/jitsi-videobridge] fix: Fixes a bug reported by @aaronkvanmeerten (#296)


#1

Only expires channels once. Fixes the values reported in statistics.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/296

-- Commit Summary --

  * fix: Fixes a bug reported by @aaronkvanmeerten

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Channel.java (8)
    M src/main/java/org/jitsi/videobridge/RtpChannel.java (10)
    M src/main/java/org/jitsi/videobridge/SctpConnection.java (15)
    M src/main/java/org/jitsi/videobridge/VideoChannel.java (10)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/296.patch
https://github.com/jitsi/jitsi-videobridge/pull/296.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/296


#2

@@ -1833,8 +1833,14 @@ else if (second == null)
      * assumes the responsibility of releasing its resources.
      */
     @Override
- public void expire()
+ public boolean expire()

Please add missing docs for return statement. Eventually {@inheritDocs} may work as well

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/296/files/7b1e2b34544411c4eb67fe032d4c1a551b7378be#r76113112


#3

@bgrozev pushed 1 commit.

eff66f8 docs: Adds an inheritDoc tag.

···


You are receiving this because you are subscribed to this thread.
View it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/296/files/7b1e2b34544411c4eb67fe032d4c1a551b7378be..eff66f8bd366f37d3beedeffe2a35b93047340a4


#4

Merged #296.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/296#event-766612321