[jitsi-dev] [jitsi/jitsi-videobridge] Fix a regression after #190 when RawUdpTransport is used. (#235)


#1

After #190 when RawUdpTransport is used the media stream never starts, because with RawUdpTransport the streamTarget is always null by definition, and so maybeStartStream() returns too early without reaching stream.start().
I mantained the setTarget / setConnector order as in #190.

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/235

-- Commit Summary --

  * Fix a regression after #190 when RawUdpTransport is used.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/RtpChannel.java (39)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/235.patch
https://github.com/jitsi/jitsi-videobridge/pull/235.diff

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/235


#2

Hi, thanks for your contribution!
If you haven't already done so, could you please make sure you sign our CLA (https://jitsi.org/icla for individuals and https://jitsi.org/ccla for corporations)? We would unfortunately be unable to merge your patch unless we have that piece :(.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/235#issuecomment-216879802


#3

Jenkins: add to whitelist

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/235#issuecomment-216996331


#4

Merged #235.

···

---
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/235#event-650781016