[jitsi-dev] [jitsi/jitsi-videobridge] Failed channels stats. (#285)


#1

Exposes the failed channels statistics in colibri stats.
You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/285

-- Commit Summary --

  * refactor(conference): enableLogging -> loggingEnabled.
  * refactor(conference): Adds getter for the loggingEnabled.
  * feat(stats): Exposes the total number of failed channels.

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Conference.java (27)
    M src/main/java/org/jitsi/videobridge/RtpChannel.java (27)
    M src/main/java/org/jitsi/videobridge/Videobridge.java (48)
    M src/main/java/org/jitsi/videobridge/stats/VideobridgeStatistics.java (26)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/285.patch
https://github.com/jitsi/jitsi-videobridge/pull/285.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285


#2

@@ -201,6 +201,13 @@
     private Pattern shutdownSourcePattern;

     /**
+ * Keeps track of the total number of failed channels. (look at
+ * @{link RtpChannel} for the definition of "failed").
+ */
+ private Map<MediaType, Integer> totalNumberOfFailedChannelsMap

Why not just use two atomic integers and remove the synchronization logic?

···


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285/files/beef4716b3a148aeac90cbb939cb71198a50d94c..1f9831f7db56f2dfc71d76bc10c71bd58c7b39ae#r74815944


#3

@@ -138,6 +138,18 @@
      */
     public static final String VIDEOSTREAMS = "videostreams";

+ /**
+ * The name of the total number of failed audio channels statistic.
+ */
+ private static final String TOTAL_FAILED_AUDIO_CHANNELS

Can we use names that fit the convention?

···


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285/files/beef4716b3a148aeac90cbb939cb71198a50d94c..1f9831f7db56f2dfc71d76bc10c71bd58c7b39ae#r74816229


#4

Closed #285.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285#event-756076052


#5

@paweldomas has a better way of doing some of these things here https://github.com/jitsi/jitsi-videobridge/pull/272/commits/b3bdcd81193af19555e78c925475923393fdde16. Will cherry-pick his commit and adapt my changes to his.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285#issuecomment-239898850


#6

@@ -70,6 +70,12 @@
     private final List<Content> contents = new LinkedList<>();

     /**
+ * A boolean flag that determines whether logging should be enabled for
+ * this conference.
+ */
+ private final boolean loggingEnabled;

This clashes with the implementation in #284 (which implements pretty much the same). Do you prefer to use this version?

···


You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/285/files/237809e2e5b4835086f53063faaad0cf753c0c13..beef4716b3a148aeac90cbb939cb71198a50d94c#r74816411