[jitsi-dev] [jitsi/jitsi-videobridge] Enable lipsync by default (#304)


#1

You can view, comment on, or merge this pull request online at:

  https://github.com/jitsi/jitsi-videobridge/pull/304

-- Commit Summary --

  * cfg: Enable lipsync by default

-- File Changes --

    M src/main/java/org/jitsi/videobridge/Endpoint.java (2)

-- Patch Links --

https://github.com/jitsi/jitsi-videobridge/pull/304.patch
https://github.com/jitsi/jitsi-videobridge/pull/304.diff

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/304


#2

Merged #304.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/304#event-779853117


#3

will this being enabled break anything for users who don't need it? we can add something to the config to disable it, but we only update every so often and i may forget when the time comes around. just curious what the behavior will be if this is enabled but mixing is being used.

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/304#issuecomment-245075024


#4

@brianh5 sorry about that, but we need that change in the master. If you add this config option now, then older JVB will just ignore it until updated. Does that make sense ?

I can not tell about mixing. Maybe @gpolitis will know more

···

--
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub:
https://github.com/jitsi/jitsi-videobridge/pull/304#issuecomment-245077871